Skip to content

Update and clean gpuCI scripts - #440

Merged
ajschmidt8 merged 7 commits into
rapidsai:branch-0.17from
msadang:gpuciscripts-update
Dec 7, 2020
Merged

ajschmidt8 merged 7 commits into
rapidsai:branch-0.17from
msadang:gpuciscripts-update

Conversation

@msadang

@msadang msadang commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

In CI folder the following changes have been made:

  • Remove logger function and replace all logger calls with gpuci_logger

  • Removed all ellipses ... from logger messages

  • Prepend /opt to the conda path in PATH variable

  • Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)

  • Replace source activate with the following:
    . /opt/conda/etc/profile.d/conda.sh
    conda activate rapids

  • Replace conda list with more verbose information:
    conda info
    conda config --show-sources
    conda list --show-channel-urls

  • Update Copyright year in the top of scripts to include 2020 if applicable

  • Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}

  • Set gpuci_conda_retry flags in cpu/build.sh
    Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
    export GPUCI_CONDA_RETRY_MAX=1
    export GPUCI_CONDA_RETRY_SLEEP=30

  • Replace calls to gcc and g++ with $CC and $CXX respectively

@msadang
msadang requested a review from a team as a code owner November 10, 2020 01:52

@madsbk madsbk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clean up @msadang!

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like my review comments from the raft PR below will apply here as well (remove gpuci_logger function and fix export PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}).

NVIDIA/raft#92 (review)

@codecov-io

codecov-io commented Nov 13, 2020

Copy link
Copy Markdown

Codecov Report

Merging #440 (d83fd62) into branch-0.17 (e7d0c34) will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17     #440      +/-   ##
===============================================
+ Coverage        89.83%   90.57%   +0.74%     
===============================================
  Files               15       14       -1     
  Lines             1121      796     -325     
===============================================
- Hits              1007      721     -286     
+ Misses             114       75      -39     
Impacted Files Coverage Δ
dask_cuda/is_device_object.py 88.88% <0.00%> (-3.71%) ⬇️
dask_cuda/utils.py 90.00% <0.00%> (-0.66%) ⬇️
dask_cuda/local_cuda_cluster.py 81.01% <0.00%> (-0.24%) ⬇️
dask_cuda/device_host_file.py 98.64% <0.00%> (-0.22%) ⬇️
dask_cuda/cli/dask_cuda_worker.py 96.77% <0.00%> (-0.06%) ⬇️
dask_cuda/proxy_object.py
dask_cuda/cuda_worker.py 71.95% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d0c34...46ddecf. Read the comment docs.

@msadang

msadang commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

It looks like my review comments from the raft PR below will apply here as well (remove gpuci_logger function and fix export PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}).

rapidsai/raft#92 (review)

gpuci_logger and parallel level changed.

Comment thread ci/cpu/build.sh
@msadang msadang changed the title [WIP] - Gpuciscripts clean and update Gpuciscripts clean and update Dec 2, 2020
@msadang msadang added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2020

@pentschev pentschev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msadang !

@pentschev

Copy link
Copy Markdown
Member

@dillon-cullinan could you approve/merge?

@ajschmidt8
ajschmidt8 merged commit aa2cd07 into rapidsai:branch-0.17 Dec 7, 2020
@pentschev pentschev changed the title Gpuciscripts clean and update Update and clean gpuCI scripts Dec 7, 2020
@msadang
msadang deleted the gpuciscripts-update branch December 9, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants